Skip to content

[0-size Tensor No.41、125、296] Add 0-size Tensor support for cumsum - #72799

Merged
luotao1 merged 2 commits into
PaddlePaddle:developfrom
co63oc:fix89
May 21, 2025
Merged

[0-size Tensor No.41、125、296] Add 0-size Tensor support for cumsum#72799
luotao1 merged 2 commits into
PaddlePaddle:developfrom
co63oc:fix89

Conversation

@co63oc

@co63oc co63oc commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Category

Operator Mechanism

PR Types

Others

Description

[0-size Tensor No.41、125、296] Add 0-size Tensor support for cumsum
cumsum的反向使用cumsum正向kernel，所以不用修改
image
infermeta shape推导正确不用修改
kernel修复修改cpu, gpu, xpu，不需要修改onednn sparse selectrows

logcumsumexp正向使用 cumsum，已修改反向
infermeta shape推导同cumsum不用修改
kernel修复修改cpu, gpu，其他不需要修改

PaddleAPITest 测试通过
image

@paddle-bot

paddle-bot Bot commented May 20, 2025

Copy link
Copy Markdown

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label May 20, 2025
@co63oc co63oc changed the title CI测试不review [0-size Tensor No.41、125] Add 0-size Tensor support for cumsum May 20, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label May 20, 2025
@luotao1 luotao1 mentioned this pull request May 20, 2025
Closed
@DanielSun11

DanielSun11 commented May 20, 2025

Copy link
Copy Markdown
Contributor

@co63oc

co63oc commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

cumsum的反向使用cumsum正向kernel，所以不用修改
image
infermeta shape推导正确不用修改
kernel修复修改cpu, gpu, xpu，不需要修改onednn sparse selectrows

logcumsumexp正向使用 cumsum，已修改反向
infermeta shape推导同cumsum不用修改
kernel修复修改cpu, gpu，其他不需要修改

PaddleAPITest 测试通过
image

DanielSun11
DanielSun11 reviewed May 20, 2025
View reviewed changes
Comment thread test/legacy_test/test_cumsum_op_0size.py Resolved
@DanielSun11

DanielSun11 commented May 20, 2025

Copy link
Copy Markdown
Contributor

cum_kernel.cc
image
PR-CI-Coverage中有几行代码没覆盖到 ，请检查下单测的case。可尝试指定place来指定在cpu/gpu上执行

@co63oc

co63oc commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

(https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/12835530/stage/19029778/0?jump=latestJob)中有几行代码没覆盖到 ，请检查下单测的case。可尝试指定place来指定在cpu/gpu上执行

CI有不同CPU/GPU环境测试，覆盖率问题可以豁免

@codecov-commenter

codecov-commenter commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@0df410c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/kernels/cpu/cum_kernel.cc 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #72799   +/-   ##
==========================================
  Coverage           ?   33.33%           
==========================================
  Files              ?        1           
  Lines              ?        3           
  Branches           ?        0           
==========================================
  Hits               ?        1           
  Misses             ?        2           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@co63oc

co63oc commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

PR-CE-CINN-Framework 打开后状态为成功
image

@luotao1

luotao1 commented May 21, 2025

Copy link
Copy Markdown
Collaborator

PR-CE-CINN-Framework 打开后状态为成功

已标记成功

DanielSun11
DanielSun11 approved these changes May 21, 2025
View reviewed changes

@DanielSun11 DanielSun11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
luotao1 requested a review from wanghuancoder May 21, 2025 03:57
wanghuancoder
wanghuancoder approved these changes May 21, 2025
View reviewed changes

@wanghuancoder wanghuancoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
luotao1 merged commit 22fd52c into PaddlePaddle:develop May 21, 2025
@co63oc
co63oc deleted the fix89 branch May 21, 2025 12:34
co63oc added a commit to co63oc/Paddle that referenced this pull request May 22, 2025
@co63oc
[0-size Tensor No.41、125] Add 0-size Tensor support for cumsum (Paddl…
363b489 
…ePaddle#72799)
@co63oc co63oc changed the title [0-size Tensor No.41、125] Add 0-size Tensor support for cumsum [0-size Tensor No.41、125、296] Add 0-size Tensor support for cumsum May 26, 2025
@co63oc co63oc mentioned this pull request Aug 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes
@DanielSun11 DanielSun11 DanielSun11 approved these changes

Assignees

@luotao1 luotao1

@wanghuancoder wanghuancoder

@DanielSun11 DanielSun11

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@co63oc @DanielSun11 @codecov-commenter @luotao1 @wanghuancoder